fix: deadlock on recursive emit_with_ack calls #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @1c3t3a, I came across an issue while trying to call
emit_with_ack
recursively like so:I noticed that the second callback is never executed, and the program just waits indefinitely. After some quick debugging, I drilled down the problem to a deadlock of
self.outstanding_acks
in the RawClient.Steps to reproduce
I created a minimal example which can be used to reproduce the issue: https://github.com/bastilimbach/rust-socketio-deadlock
The steps are written in the README.
Remarks
I'm quite new to Rust and would appreciate any requests to changes, etc.
Also, I wasn't sure how to write tests for this. I could create a test which calls
emit_with_ack
recursively and call it a day but I'm not sure if this is really the way to go here. Looking forward to suggestions!